pxlrbt/filament-environment-indicator
2
0
Fork 0
Code Issues Pull requests Projects Releases 20 Packages Activity

Add Border Width Support #29

Merged
tonypartridge merged 4 commits from patch-2 into main 2025-11-10 12:22:30 +00:00
Conversation 5 Commits 4 Files changed 1 +10 -1
tonypartridge commented 2025-11-10 11:22:29 +00:00 (Migrated from github.com)
Copy link
No description provided.
pxlrbt (Migrated from github.com) reviewed 2025-11-10 11:41:44 +00:00
src/EnvironmentIndicatorPlugin.php
pxlrbt (Migrated from github.com) commented 2025-11-10 11:41:44 +00:00
Copy link

@tonypartridge Is it needed to target both sidebar and topbar again? Also is the height needed again? We just removed that some versions ago.

@tonypartridge Is it needed to target both sidebar and topbar again? Also is the height needed again? We just removed that some versions ago.
tonypartridge (Migrated from github.com) reviewed 2025-11-10 11:43:55 +00:00
src/EnvironmentIndicatorPlugin.php
tonypartridge (Migrated from github.com) commented 2025-11-10 11:43:55 +00:00
Copy link

Nope, mine was clearly a few versions out of date. Will update it.

Nope, mine was clearly a few versions out of date. Will update it.
tonypartridge (Migrated from github.com) reviewed 2025-11-10 11:49:17 +00:00
src/EnvironmentIndicatorPlugin.php
tonypartridge (Migrated from github.com) commented 2025-11-10 11:49:17 +00:00
Copy link

@pxlrbt updated and added back the rgb wrap, since according to the docs using the color classes will as such require it to be wrapped in rgb() unsure why that was removed tbh unless people were adding hex colors and not using the Filament Color class as per the docs.

@pxlrbt updated and added back the rgb wrap, since according to the docs using the color classes will as such require it to be wrapped in rgb() unsure why that was removed tbh unless people were adding hex colors and not using the Filament Color class as per the docs.
pxlrbt (Migrated from github.com) reviewed 2025-11-10 11:59:25 +00:00
src/EnvironmentIndicatorPlugin.php
pxlrbt (Migrated from github.com) commented 2025-11-10 11:59:25 +00:00
Copy link

I guess that wasn't used intentionally.

You still kept the .fi-sidebar. Is that required?

I guess that wasn't used intentionally. You still kept the `.fi-sidebar`. Is that required?
tonypartridge (Migrated from github.com) reviewed 2025-11-10 12:02:49 +00:00
src/EnvironmentIndicatorPlugin.php
tonypartridge (Migrated from github.com) commented 2025-11-10 12:02:49 +00:00
Copy link

I guess that wasn't used intentionally.

You still kept the .fi-sidebar. Is that required?

My bad, too fast on my phone. Updated correctly.

> I guess that wasn't used intentionally. > > You still kept the `.fi-sidebar`. Is that required? My bad, too fast on my phone. Updated correctly.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pxlrbt/filament-environment-indicator!29
No description provided.