pxlrbt/filament-environment-indicator
2
0
Fork 0
Code Issues Pull requests Projects Releases 20 Packages Activity

fix: set default of TRUE for badge and border #14

Closed
trovster wants to merge 1 commit from patch-1 into main
pull from: patch-1
merge into: pxlrbt:main
Conversation 2 Commits 1 Files changed 1 +2 -8
trovster commented 2025-01-03 14:42:04 +00:00 (Migrated from github.com)
Copy link

This change matches the documentation which says "By default, both indicators are displayed".

This also matches my expectations for the plugin functionality. I wanted a banner to be displayed on production and local, so I could visually identify each environment easily.

This change matches the documentation which says "By default, both indicators are displayed". This also **matches my expectations** for the plugin functionality. I wanted a banner to be displayed on production and local, so I could visually identify each environment easily.
pxlrbt commented 2025-01-04 05:04:52 +00:00 (Migrated from github.com)
Copy link

Thanks for your PR and mentioning the unclear part of the docs. I added "on non-production environments" to the docs, because I want to keep the default this way and I don't want to introduce a BC in that behaviour.

You are free to overwrite this for your apps though.

Thanks for your PR and mentioning the unclear part of the docs. I added "on non-production environments" to the docs, because I want to keep the default this way and I don't want to introduce a BC in that behaviour. You are free to overwrite this for your apps though.
👍 1
trovster commented 2025-01-04 16:08:34 +00:00 (Migrated from github.com)
Copy link

That's fair. I did wonder whether it made sense to update the documentation.

That's fair. I did wonder whether it made sense to update the documentation.
👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pxlrbt/filament-environment-indicator!14
No description provided.