Pages with route parameters break page registration. #33

New issue

Closed

opened 2023-10-13 11:50:13 +00:00 by oddvalue · 0 comments

oddvalue commented

2023-10-13 11:50:13 +00:00

(Migrated from github.com)

            if ($page::shouldRegisterNavigation() === false) {
                continue;
            }

If having pages that aren't in the navigation is an intended feature of this package then maybe that could be togglable? Or some way to excluded certain pages added?

This has already been mentioned in #17 but we have a few pages within our application that have route parameters. One possible solution would be to check whether or not the page should register navigation in RegisterPages: ```php if ($page::shouldRegisterNavigation() === false) { continue; } ``` If having pages that aren't in the navigation is an intended feature of this package then maybe that could be togglable? Or some way to excluded certain pages added?