Filenames that contain . are missing the extension #95

Closed
opened 2023-07-14 14:00:08 +00:00 by pxlrbt · 0 comments
pxlrbt commented 2023-07-14 14:00:08 +00:00 (Migrated from github.com)

This code breaks exports with filenames that contain a dot.

protected function ensureFilenameHasExtension(string $filename): string
{
    return Str::contains($filename, '.')
        ? $filename
        : $filename.'.'.$this->getDefaultExtension();
}
This code breaks exports with filenames that contain a dot. ```php protected function ensureFilenameHasExtension(string $filename): string { return Str::contains($filename, '.') ? $filename : $filename.'.'.$this->getDefaultExtension(); } ```
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pxlrbt/filament-excel#95
No description provided.