Add test suite #116

Open
opened 2023-09-05 06:45:17 +00:00 by pxlrbt · 4 comments
pxlrbt commented 2023-09-05 06:45:17 +00:00 (Migrated from github.com)
No description provided.
noondaysun commented 2026-08-12 16:20:00 +00:00 (Migrated from github.com)

hi there

can I help with adding tests here? If so do you have preferences? Pest, or phpunit? Do you have any specific guidelines for contributing?

Thanks, and kind regards
Feighen

hi there can I help with adding tests here? If so do you have preferences? Pest, or phpunit? Do you have any specific guidelines for contributing? Thanks, and kind regards Feighen
pxlrbt commented 2026-08-12 16:35:29 +00:00 (Migrated from github.com)

If you want to add tests here, that would be great. I haven't thought much about it yet. I guess for fully testing the library we'd need to write an Excel file and read it again and test against the results. Most important would be to test complex form/table scenarios when generating the Filament column to Export column mapping. That magic occasionally breaks and it would be great to test it against the latest Filament version. I'd go with PEST.

If you want to add tests here, that would be great. I haven't thought much about it yet. I guess for fully testing the library we'd need to write an Excel file and read it again and test against the results. Most important would be to test complex form/table scenarios when generating the Filament column to Export column mapping. That magic occasionally breaks and it would be great to test it against the latest Filament version. I'd go with PEST.
noondaysun commented 2026-08-13 10:02:26 +00:00 (Migrated from github.com)

I'll try start over the weekend. Think the idea would be to find a simple place to start then iterate. If you're happy I'll automate using github actions

I'll try start over the weekend. Think the idea would be to find a simple place to start then iterate. If you're happy I'll automate using github actions
pxlrbt commented 2026-08-15 12:02:52 +00:00 (Migrated from github.com)

Just FYI I just added some first tests with the last PR.

Just FYI I just added some first tests with the last PR.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pxlrbt/filament-excel#116
No description provided.