Display git tag and (short) hash #27
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
pxlrbt/filament-environment-indicator#27
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hi,
Instead of displaying the branch, it would be nice to be able to display the git tag and short hash.
Usually, our display look like this:
Dev: 12345678 (hash only)
Preprod: 2.2.0-rc.1 - 12345678 (rc tag + hash)
Prod: 2.2.0 - 12345678 (tag + hash)
Tag + Hash could get quite long, don't you think? I don't mind a PR adding these features. Maybe a new method
->showGitInfo()which accepts a Closure getting the information.->showGitBranch()should then use->showGitInfo()and use a Closure to identify the branch.I don't think it's that long, I haven't installed the plugin yet so I'm not sure how it is displayed, but perhaps it could be a tooltip
Hi! I'm a student in the CodePath AI301 program, an AI open-source practicum I'm doing this summer. I'd love to work on this issue since it caught my eye and I have experience working with Laravel and Filament. I’ll start by exploring how to efficiently show the git tag and hash. Please let me know if there are any active discussions or edge cases I should keep in mind. Looking forward to working on this!
@SujalRatnaTamrakar The only edge case would be long version numbers. We shouldn't increase the badge size. It should stay compact. Git branch/Git Hash should be opt-in. Also consider both options active at the same time.