pxlrbt/filament-activity-log

Missing tests #47

New issue

Open

opened 2024-07-13 10:34:30 +00:00 by digitall-it · 1 comment

digitall-it commented

2024-07-13 10:34:30 +00:00

(Migrated from github.com)

It would be nice if this package had some tests and start listing which ones may be in the scope. For example, testing features of the underlying Spatie package or Filament features could be meaningless. Instead, things like checking if the field translations are respected, or if the restoration feature actually does the job, may be interesting test cases worth looking after.

It would be nice if this package had some tests and start listing which ones may be in the scope. For example, testing features of the underlying Spatie package or Filament features could be meaningless. Instead, things like checking if the field translations are respected, or if the restoration feature actually does the job, may be interesting test cases worth looking after.

pxlrbt commented

2024-07-19 15:13:22 +00:00

(Migrated from github.com)

Definitely interesting, but I currently don't have the time to implement this myself. I'd be happy to accept a good PR though.

Definitely interesting, but I currently don't have the time to implement this myself. I'd be happy to accept a good PR though.

Sign in to join this conversation.

No labels

good first issue

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

pxlrbt/filament-activity-log#47

No description provided.